Fail the whole EVM transaction if an internal Scilla call fails #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
force-pushed
the
scilla-call-precompile-error-jh
branch
from
5e53e17 to
7ba1698
Compare
|
Bencher Report| Branch | scilla-call-precompile-error-jh |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8,407,200.00 (-8.04%) | 10,517,683.09 (79.93%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,721,500,000.00 (-20.26%) | 2,936,376,541.54 (58.63%) |
|
Looks good to me. Push back dates and rebase and i'll approve |
JamesHinshelwood
force-pushed
the
scilla-call-precompile-error-jh
branch
from
7ba1698 to
c06bb52
Compare
JamesHinshelwood
force-pushed
the
scilla-call-precompile-error-jh
branch
from
cb5de64 to
9dd6f26
Compare
86667
previously approved these changes
Dec 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
JamesHinshelwood
force-pushed
the
scilla-call-precompile-error-jh
branch
from
9dd6f26 to
6173bbc
Compare
frankmeds
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(if the contract is whitelisted)
This PR also adds support for specifying 'forks' in configuration which lets us diverge execution behaviour based on the block height.